-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.101.7 preparation #199
v0.101.7 preparation #199
Conversation
Codecov Report
@@ Coverage Diff @@
## rel-0.101 #199 +/- ##
=============================================
- Coverage 95.09% 95.03% -0.07%
=============================================
Files 16 17 +1
Lines 3711 3723 +12
=============================================
+ Hits 3529 3538 +9
- Misses 182 185 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Shouldn't we pick up rcgen 0.11.3 and its associated fix? |
That still needs to be published, 0.11.2 is the latest available. I thought it was OK to not block on that since it's a dev-dep. WDYT? |
I think it would have to be a 0.12.0 release too right? Since this commit isn't semver compatible, and |
Yeah, probably no need to block on it. I thought 0.11.3 was the pem feature fix but looks like that was wrong. |
Oh, I think I'm wrong. Sorry! I was looking at the tags on the repo where 0.11.2 is the last, but we published the PEM fix to crates as 0.11.3. I'll adjust and see if I can push the missing tag on the upstream repo. |
Done: https://github.com/rustls/rcgen/releases/tag/v0.11.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think we should hold off publishing this until we're also ready to publish rustls 0.21.8 -- which maybe we want to hold off on to see if the performance regression is fixed? |
|
Description
This branch targets the
rel-0.101
release branch to make a point release to upgrade to ring 0.17. This will unblock a Rustls 0.21 point release that does the same.This involves bringing the work from #193 onto the rel-0.101 branch. I didn't cherry-pick the commits directly because the restructuring of the modules in
main
made it more challenging to resolve conflicts than to re-implement the changes wholesale.The
rcgen
update (from #189 and #195) isn't mentioned in the proposed release notes since it's a dev dependency. We also don't typically mention MSRV updates, so its omitted as well.Proposed Release Notes
*ring*
to 0.17, anduntrusted
to 0.9. Note: sinceunstrusted
appears in theError
API this may be a breaking change for applications using twountrusted
versions.